Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(test) Add test for path forwarding with channel upgrade #6793

Merged
merged 1 commit into from
Jul 10, 2024
Merged

(test) Add test for path forwarding with channel upgrade #6793

merged 1 commit into from
Jul 10, 2024

Conversation

bznein
Copy link
Contributor

@bznein bznein commented Jul 10, 2024

Description

ref: #6578

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

@bznein bznein mentioned this pull request Jul 10, 2024
Closed
8 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'ibc-go'

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

crodriguezvega
crodriguezvega approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great work with all these e2e tests, @bznein.

Suggestion: maybe we can consider moving the test to upgradesv1_test.go or upgradesv2_test.go to have all transfer upgrade tests together?

e2e/tests/transfer/forwarding_test.go Show resolved Hide resolved
@bznein
Copy link
Contributor Author

bznein commented Jul 10, 2024 •
edited
Loading

Looks good! Great work with all these e2e tests, @bznein.

Suggestion: maybe we can consider moving the test to upgradesv1_test.go or upgradesv2_test.go to have all transfer upgrade tests together?

I thought about that, but the problem of doing that is that this test suite is the only one creating the 3 chains.

Edit: this is a more generic issue we might be facing in the future, as I'm having the same issue with the memo-callback test

gjermundgaraba
gjermundgaraba approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@gjermundgaraba gjermundgaraba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@bznein bznein added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 0eacb16 Jul 10, 2024
80 checks passed
@bznein bznein deleted the bznein/6578/upgradeTest branch July 10, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@gjermundgaraba gjermundgaraba gjermundgaraba approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

@chatton chatton Awaiting requested review from chatton

@DimitrisJim DimitrisJim Awaiting requested review from DimitrisJim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bznein @gjermundgaraba @crodriguezvega